Skip to content

Form: fields should not exceed group column width (T1326645)#33268

Merged
pharret31 merged 6 commits intoDevExpress:26_1from
pharret31:26_1_3925-form-tagbox-exceeds-the-group-column-when-the-selected-tag-items-exceed-the-field-container-t1326645
Apr 15, 2026
Merged

Form: fields should not exceed group column width (T1326645)#33268
pharret31 merged 6 commits intoDevExpress:26_1from
pharret31:26_1_3925-form-tagbox-exceeds-the-group-column-when-the-selected-tag-items-exceed-the-field-container-t1326645

Conversation

@pharret31
Copy link
Copy Markdown
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Apr 14, 2026
@pharret31 pharret31 requested a review from a team as a code owner April 14, 2026 17:34
Copilot AI review requested due to automatic review settings April 14, 2026 17:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression fix for Form layout so editor content (notably TagBox with many selected items) can shrink within a group column instead of overflowing.

Changes:

  • Adjusted Form CSS to allow field content to shrink (min-width: 0) in left/right label layouts.
  • Added a QUnit regression test covering TagBox width behavior in a grouped Form (T1326645).
  • Cleaned up several test titles/assertion messages for clarity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.markup.tests.js Adds TagBox regression test and updates wording; includes theme + TagBox imports needed for the scenario.
packages/devextreme-scss/scss/widgets/base/_form.scss Adds min-width: 0 to help field item content shrink instead of overflowing its column.

Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.markup.tests.js Outdated
Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.markup.tests.js Outdated
Comment thread packages/devextreme-scss/scss/widgets/base/_form.scss Outdated
Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.form/form.markup.tests.js Outdated
Copilot AI review requested due to automatic review settings April 15, 2026 09:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 15, 2026 09:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@pharret31 pharret31 merged commit da51393 into DevExpress:26_1 Apr 15, 2026
132 of 133 checks passed
@pharret31 pharret31 deleted the 26_1_3925-form-tagbox-exceeds-the-group-column-when-the-selected-tag-items-exceed-the-field-container-t1326645 branch April 15, 2026 10:19
pharret31 added a commit to pharret31/DevExtreme that referenced this pull request Apr 15, 2026
pharret31 added a commit to pharret31/DevExtreme that referenced this pull request Apr 15, 2026
@pharret31 pharret31 changed the title Form: fields should not exceed group column width when many items are selected (T1326645) Form: fields should not exceed group column width (T1326645) Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants